commit 6cbf508f3769c2055fe3f6b2ea358cccff6e02cf Author: Gal Paikin Date: Tue Oct 13 11:28:34 2020 +0200 Add more fine logging to SubmitStrategyOp These additional logging allow us to track how many times postUpdate was called for each change. Also, it allows tracking the "submitter" field which was occasionally null. Change-Id: I3e619576657e1b3e57f5e767d36f5e926d4e0c36 diff --git a/java/com/google/gerrit/server/submit/SubmitStrategyOp.java b/java/com/google/gerrit/server/submit/SubmitStrategyOp.java index 3b77dd9..3430047 100644 --- a/java/com/google/gerrit/server/submit/SubmitStrategyOp.java +++ b/java/com/google/gerrit/server/submit/SubmitStrategyOp.java @@ -461,9 +461,12 @@ abstract class SubmitStrategyOp implements BatchUpdateOp { // If we naively execute postUpdate even if the change is already merged when updateChange // being, then we are subject to a race where postUpdate steps are run twice if two submit // processes run at the same time. - logger.atFine().log("Skipping post-update steps for change %s", getId()); + logger.atFine().log( + "Skipping post-update steps for change %s; submitter is %s", getId(), submitter); return; } + logger.atFine().log( + "Begin post-update steps for change %s; submitter is %s", getId(), submitter); postUpdateImpl(ctx); if (command != null) { @@ -483,6 +486,9 @@ abstract class SubmitStrategyOp implements BatchUpdateOp { } } + logger.atFine().log( + "Begin sending emails for submitting change %s; submitter is %s", getId(), submitter); + // Assume the change must have been merged at this point, otherwise we would // have failed fast in one of the other steps. try {